Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] [Live Share] Restricting language services to local files #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lostintangent
Copy link

In preparation for Visual Studio Live Share adding support for "guests" to receive remote language services for Less, this PR simply updates the current DocumentSelector to be limited to file and untitled (unsaved) files. This way, when someone has the Less extension installed, and joins a Live Share session (where files use the vsls: scheme), their language services will be entirely derived from the remote/host side, which provides a more accurate and project-wide experience (guests in Live Share don't have local file access to the project they're collaborating with).

Note: As an example, the TypeScript/JavaScript language services that come in-box with VS Code already have this scheme restriction, and so this PR replicates that behavior.

@lostintangent
Copy link
Author

@mrmlnc I'm not sure whether the build failure is due to this PR? Is there anything I could do to help unblock it?

@mrmlnc
Copy link
Owner

mrmlnc commented Apr 29, 2018

Hi, @lostintangent,

Sorry for the long answer (difficult week). In recent months, I have little time to support my projects. In the summer I plan to take up this project again.

I understand correctly that you want to add untitled document support to this plugin, not to Less, which is contained in the editor?

I'm not sure whether the build failure is due to this PR?

Unfortunately, this repository is a bit outdated and needs cosmetic repairs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants