Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-99: use "findDocumentLinks2" method #100

Merged
merged 5 commits into from
Jan 4, 2020
Merged

Conversation

mrmlnc
Copy link
Owner

@mrmlnc mrmlnc commented Dec 8, 2019

This is a fix for #99.

Yeap, right now it looks dirty. But in the future I would like to separate the concept of parser and link search. Something like:

https://github.com/microsoft/vscode/blob/2bb6cfc16a88281b75cfdaced340308ff89a849e/extensions/css-language-features/server/src/cssServerMain.ts#L231-L249

@mrmlnc mrmlnc force-pushed the ISSUE-99_find_links2 branch from 963e16f to cc348c8 Compare December 8, 2019 13:25
@octref
Copy link
Collaborator

octref commented Dec 10, 2019

That's ok for now 👍
Parser should return whatever that's in the import path, and it should be up to a link resolver to resolve the dependencies according to SASS logic.

@mrmlnc mrmlnc merged commit a50cfd1 into master Jan 4, 2020
@mrmlnc mrmlnc deleted the ISSUE-99_find_links2 branch January 4, 2020 22:19
@mrmlnc mrmlnc restored the ISSUE-99_find_links2 branch January 4, 2020 22:19
@mrmlnc mrmlnc deleted the ISSUE-99_find_links2 branch January 4, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants