Skip to content

Commit

Permalink
Add failing test for sinonjs#852
Browse files Browse the repository at this point in the history
  • Loading branch information
mroderick committed Sep 25, 2015
1 parent 3edf7cb commit d62d2f4
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions test/issues/issues-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,20 @@
clock = sinon.useFakeTimers(new Date("2015-1-5").getTime());
assert.equals(clock.now, Date.now());
}
},

"#852 - createStubInstance on intherited constructors": {

This comment has been minimized.

Copy link
@fatso83

fatso83 Sep 25, 2015

Might just as well say sinonjs#847
edit: haha, nevermind, you were faster.

"must not throw error": function () {
var A = function () {};
var B = function () {};

B.prototype = Object.create(A.prototype);
B.prototype.constructor = A;

refute.exception(function () {
var b = sinon.createStubInstance(B); // eslint-disable-line no-unused-vars
});
}
}
});
}(this));

1 comment on commit d62d2f4

@fatso83
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. What is preventing a merge? Should another maintainer always look through the changes, or let it rest for a day or something?

Please sign in to comment.