Issue 49 remove exists forall #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to mrpowers-io#173 Add maintainers to `pyproject.toml` file * Add a `maintainers` section below the `authors` section. * Include the names and contact information of the maintainers (first version only). * Use the format `name <email>` for each maintainer. * Add a comment above the `maintainers` section to indicate its purpose.
Deprecate and remove `exists` and `forall` functions from the codebase. * Remove `exists` and `forall` functions from `quinn/functions.py`. * Remove import statements for `exists` and `forall` from `quinn/__init__.py`. * Remove tests related to `exists` and `forall` functions from `tests/test_functions.py`.
* Describe how to add ruff in IDEs like VSCode & PyCharm Following changes have been made in the file(s): * **CONTRIBUTING.md** - Remove mention of Black - Add instructions on how to add ruff to VSCode - Add instructions on how to add ruff to PyCharm
|
@SemyonSinchenko - I have created this PR pointing to the |
Add maintainers to pyproject.toml & update CONTRIBUTING.md with ruff setup for IDEs (mrpowers-io#173 and mrpowers-io#163)
|
@SemyonSinchenko - this PR is related to the issue #49 and closes it, but also partially of the issue #199. Would be great if you could review this too. |
10 tasks
SemyonSinchenko
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR will help close the #49 following changes were made to remove/deprecate the functions
existsandforallfunctions from the codebase.existsandforallfunctions fromquinn/functions.py.existsandforallfromquinn/__init__.py.existsandforallfunctions fromtests/test_functions.py.Types of changes
Further comments