[stdlib] Honours the Python dict.popitem() LIFO ordering

Signed-off-by: Manuel Saelices <[email protected]>
msaelices · May 30, 2024 · a034f7b · a034f7b
1 parent 2e45b91
commit a034f7b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/stdlib/src/collections/dict.mojo b/stdlib/src/collections/dict.mojo
@@ -810,7 +810,7 @@ struct Dict[K: KeyElement, V: CollectionElement](
         """
         if self.size == 0:
             raise "KeyError: popitem(): dictionary is empty"
-        var entry = self._entries.pop(0)
+        var entry = self._entries.pop(self.size - 1)
         var entry_value = entry.value()
         self.size -= 1
         self._n_entries -= 1

diff --git a/stdlib/test/collections/test_dict.mojo b/stdlib/test/collections/test_dict.mojo
@@ -158,13 +158,13 @@ def test_popitem():
     dict["b"] = 2
 
     var t1: (String, Int) = dict.popitem()
-    assert_equal(t1[0], "a")
-    assert_equal(t1[1], 1)
+    assert_equal(t1[0], "b")
+    assert_equal(t1[1], 2)
     assert_equal(1, len(dict))
 
     var t2: (String, Int) = dict.popitem()
-    assert_equal(t2[0], "b")
-    assert_equal(t2[1], 2)
+    assert_equal(t2[0], "a")
+    assert_equal(t2[1], 1)
     assert_equal(0, len(dict))
 
     with assert_raises(contains="KeyError"):