fix min_should_match for missing-scorers

msfroh · Nov 23, 2020 · 2ff882b · 2ff882b
1 parent f69322c
commit 2ff882b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/core/search/query/boolean_query.rs b/src/core/search/query/boolean_query.rs
@@ -223,7 +223,8 @@ impl<C: Codec> Weight<C> for BooleanWeight<C> {
             }
             match scorers.len() {
                 0 => None,
-                1 => Some(scorers.remove(0)),
+                // min_should_match
+                //1 => Some(scorers.remove(0)),
                 _ => Some(Box::new(DisjunctionSumScorer::new(
                     scorers,
                     self.needs_scores,

diff --git a/src/core/search/scorer/disjunction_scorer.rs b/src/core/search/scorer/disjunction_scorer.rs
@@ -34,7 +34,7 @@ impl<T: Scorer> DisjunctionSumScorer<T> {
         needs_scores: bool,
         min_should_match: i32,
     ) -> DisjunctionSumScorer<T> {
-        assert!(children.len() > 1);
+        debug_assert!(children.len() > 0);
 
         let cost = children.iter().map(|w| w.cost()).sum();
 
@@ -121,7 +121,7 @@ impl<T: Scorer> DisjunctionMaxScorer<T> {
         tie_breaker_multiplier: f32,
         needs_scores: bool,
     ) -> DisjunctionMaxScorer<T> {
-        assert!(children.len() > 1);
+        debug_assert!(children.len() > 0);
 
         let cost = children.iter().map(|w| w.cost()).sum();