Feature/eliminate abstract class hierarchy #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irtualized cloud environments inital commit
…psulate common functionality handled by copy-paste before
… available before Java 19 and therefore broke remote GitHub build
…d cpuMax wattages
…of benchmark workload on different platforms, some refactoring benchmark
…estimation-measurement
…2.0-SNAPSHOT since this is a relevant new feature
…nitorConfig instead of MeasureMethod
… not needed anymore
…rty since not used
…ationReader and CommaSeparaedValues reader shared the same code; LibreHardwareMonitorReader still overrides that default impl.
keilhofh
approved these changes
Jul 12, 2024
src/main/java/group/msg/jpowermonitor/measurement/est/EstimationReader.java
Outdated
Show resolved
Hide resolved
src/main/java/group/msg/jpowermonitor/util/CpuAndThreadUtils.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminated the somewhat ugly inheritance hierarchy regarding the interface "MeasureMethod" and the abstract class "AbstractCommonReader" by smart refactoring.
Removed the common methods as well as the abstract class because those were only needed by the "JPowerMonitorExtension" anyways - call them directly in "JPowerMonitorConfig" instead going the extra mile through "MeasureMethod" therefore.