Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from readthedocs to mkdocs (#1432) #345

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Switch from readthedocs to mkdocs (#1432) #345

merged 1 commit into from
Jan 9, 2023

Conversation

raylim
Copy link
Contributor

@raylim raylim commented Dec 30, 2022

No description provided.

@raylim raylim self-assigned this Dec 30, 2022
@raylim
Copy link
Contributor Author

raylim commented Jan 3, 2023

A few notes:

  • I merged the two github actions yaml files into one that handles both build and release (fixed a bug with caching)
  • I changed to symlinks for the tutorials instead of the previous workaround
  • There's some random job failures with the unit tests (re-trying the build a couple times seems to do the trick)
  • I converted rst files to markdown as rst isn't supported by mkdocs

@raylim
Copy link
Contributor Author

raylim commented Jan 4, 2023

Another note: the CLI documentation looks a bit off due to this outstanding bug: mkdocs/mkdocs-click#59

@armaank
Copy link
Collaborator

armaank commented Jan 4, 2023

I made a minor change to fix the navigation heading for the 'publication' page, and also symlink-ed index.md in the docs to README.md, so that they are always in sync. Only issue is that the logo href in the github README.md can't be a relative path, so once this branch is merged into dev, the path can be updated (it's currently referring to a logo in a branch from ages ago)

Copy link
Collaborator

@armaank armaank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. The auto-generated api docs are now visible and readable on the doc site. It'll be much easier to read, update and fix the documentation this way. The navigation is also improved.

For next steps on this front, I think we'll just need to have a discussion about the look. Right now we're using the default theme, so there is room for experimentation if we want.
Regarding the formatting on the existing doc strings, let's leave them be for now and pick them off later, it isn't urgent (ideally an improved cli runner won't require additional characters like that, a discussion for later).

@raylim
Copy link
Contributor Author

raylim commented Jan 9, 2023

squashed some commits

feat: deploy wheel to pypi and build docs with github actions

fix: update docs to remove references to readthedocs

ci: fix dependency caching

ci: add mkdocs build step

docs: fix tutorials for mkdocs

ci: fix mkdocs build and deploy

docs: fix cli docstring error

fix: torch trainer api update

docs: change workflow badge to github actions. remove outdated references to circleci and sphinx

docs: update documentation generation guide for mkdocs

docs: add troubleshooting for poetry installation hanging

docs: add last known working version for mamba and conda

build: freeze pip version in environment.yml

docs: symlink readme to index.md, change in nav names

docs: symlink luna logo
@raylim raylim merged commit bd129ed into dev Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants