Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additional ssr fixes #15

Merged
merged 2 commits into from
Apr 29, 2021
Merged

additional ssr fixes #15

merged 2 commits into from
Apr 29, 2021

Conversation

kamholz
Copy link
Contributor

@kamholz kamholz commented Apr 27, 2021

This is a bit more efficient/clearer and fixes the issue I mentioned in my last comment.

@kamholz kamholz changed the title improved itemHtml fix additional ssr fixes Apr 27, 2021
@kamholz
Copy link
Contributor Author

kamholz commented Apr 27, 2021 •
edited
Loading

The most recent commit fixes a tricky issue where passing in a value prop would cause an infinite loop under SSR. This is because onMount never gets called on the server side, so _selectByValues would just keep calling itself forever while waiting for isInitialized. I fixed it by storing the passed-in value in initialValue and calling _selectByValues from onMount. It seems to work fine but I'd appreciate you looking it over.

@mskocik mskocik merged commit 27d443b into mskocik:master Apr 29, 2021
@mskocik
Copy link
Owner

mskocik commented Apr 29, 2021

Really like this one 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamholz @mskocik