Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests for import #28

Open
1 of 4 tasks
gallais opened this issue Mar 19, 2020 · 1 comment
Open
1 of 4 tasks

Add more tests for import #28

gallais opened this issue Mar 19, 2020 · 1 comment
Labels
good first issue Good for newcomers testing

Comments

@gallais
Copy link
Member

gallais commented Mar 19, 2020 •
edited
Loading

  • Import of f & implicit import of f (via transitive dependency) should not raise an "AmbiguousName" error when using f.

  • Diamond imports (A -> B, A -> C, B -> D, C -> D) with conflicting definitions
    but not used in the main (=> should work just fine)

  • Diamond imports & use conflicting definition (=> should raise "AmbiguousName")

  • Imports in a mary page
@gallais gallais added good first issue Good for newcomers testing labels Mar 19, 2020
gallais added a commit that referenced this issue Mar 19, 2020
@gallais
[ re #28 ] Test for hidden import
e0984b0 
'length' imports 'list' which declares 'map'
'list2' declares 'map'

'import-hidden' imports 'length' and 'list2' but not 'list'.
The resulting global environment has 2 'map' but only one is in
scope so everything works out just fine!
gallais added a commit that referenced this issue Mar 19, 2020
@gallais
[ re #28 ] Test for hidden import
a319cd9 
'length' imports 'list' which declares 'map'
'list2' declares 'map'

'import-hidden' imports 'length' and 'list2' but not 'list'.
The resulting global environment has 2 'map' but only one is in
scope so everything works out just fine!
@gallais
Copy link
Member Author

gallais commented May 1, 2020

Another one: ee90513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gallais