Skip to content
This repository has been archived by the owner on Aug 7, 2018. It is now read-only.

Fix cannot delete regions #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

leonmak
Copy link

@leonmak leonmak commented Mar 27, 2018

I can't seem to delete a region,
When passing in a new state with lesser objects, Object.create does not cache?

Leon Mak and others added 2 commits March 26, 2018 18:51

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
remove old region after updating
@ZuzooVn
Copy link

ZuzooVn commented Jun 2, 2018

Hey @leonmak

Do you have any sample code for delete a region with reactJS version?

Thanks

@leonmak
Copy link
Author

leonmak commented Jun 9, 2018

@ZuzooVn you could look at what I did in the code for a temporary fix https://github.com/mspae/react-wavesurfer/pull/80/files

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants