Compound Integration upgrade

[superduck35]

Upgrade type: PROXY CONTRACT UPGRADE
Affected file: CompoundIntegration.sol
Proxy address: 0xd55684f4369040c12262949ff78299f2bc9db735
New version: 1.1

Description

Upgrades the Compound Integration, addressing some UX problems.

• New function collectRewardToken allows the mStable Governor to collect the $COMP airdrops
• Withdrawing minute amounts of underlying causes withdraw to fail if the cToken and Underlying have different decimals. There is now logic to ensure that if cTokensToRedeem == 0, then just skip the redemption
• checkBalance now just calculates using the exchangeRate, instead of spending 80,000 gas to check the balanceOfUnderlying. This massively reduces gas costs for deposits into the Savings Contract

Deployment plan

• Write and comprehensively test the upgrade
• Get external PR review
  • 1st approval
  • 2nd approval
• Final manual check
• Deploy CompoundIntegration v1.1 to Ropsten/Mainnet
• Use 'DiffChecker' to validate the prev and future contracts once verified
• Call proposeUpgrade on the DelayedProxyAdmin with implementation addresses
• Verify upgrade is present in ProxyAdmin and addresses match up
• Accept on Ropsten and test
• Wait 1 week
• Accept on Mainnet FORK by unlocking the gov address
  • Test collecting the COMP
  • Test withdrawing minute amount
  • Test SavingsDeposit, interest collection etc
• Accept on Mainnet

Mainnet Details

Deployed address: 0xd4c14e145111e28a7694612978b9f5e9684afffa
AcceptUpgrade date:

Ropsten Details

Deployed address: 0x4d6b9c28b3c420a0c70ea8bbe085349b73e444e1
AcceptUpgrade date:

[haythemsellami]

LGTM!