-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rest-angular example #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @timdeschryver!
Thank you so much for this awesome example! If you don't mind, I've added a few comments to align it better with the goal we have towards examples. Let me know if those suggestions can be addressed, or need any kind of discussion.
Looking forward to hearing from you!
Thanks for the review @kettanaito |
I also run into the following problem while trying to run the angular example.
To fix it I had to change - import cookieUtils from 'cookie';
+ import * as cookieUtils from 'cookie'; EDIT: Seems like this was fixed in mswjs/msw#322 |
@timdeschryver, thanks for addressing the comments! Regarding the $ npm ls msw |
@kettanaito I came to the same conclusion 😁 |
That being said, I'm not sure why it reports a corrupted Cypress download on CI. I'll try to build and test this example locally and would also kindly ask you to do so. |
I've found an issue that mentioned the error we experienced if multiple versions of cypress were installed. The storybook tests were failing because I've installed jest v26. Let me know if this is alright, or if I have to downgrade jest to v25. |
b5e485f
to
396f93b
Compare
It looks perfectly fine! Thank you for the work on this. |
Yes, if you may, I'd kindly ask you to squash those "cypress" version commits into one that fixes the dependencies issue. Would this be possible? |
Will do, I'll try to push these changes in later today. |
396f93b
to
1bf2f67
Compare
there we go 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you once more for preparing this, @timdeschryver!
I'm so excited to have an official Angular usage example. You rock!
Welcome to contributors 🎉 |
Thank you @kettanaito |
Will do, Tim! I'm extremely happy to have you as a contributor. Looking forward to the feedback from Angular developers on this amazing integration. |
This example is also live on our Examples page on the website 🎉 |
As mentioned before, I wanted to add an angular example to this repo 🙂
It includes:
I tried to copy the setup of the react example.
If I missed something or did something wrong feel free to correct me.