Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket: Adds "setNoDelay", "setKeepAlive" and "setTimeout" methods #20

Merged
merged 12 commits into from
Jun 13, 2020
Merged

Socket: Adds "setNoDelay", "setKeepAlive" and "setTimeout" methods #20

merged 12 commits into from
Jun 13, 2020

Conversation

kettanaito
Copy link
Member

@kettanaito kettanaito commented Jun 12, 2020 •
edited
Loading

Changes

  • Implemented setNoDelay, setKeepAlive and setTimeout methods on the Socket class.
  • Refactored normalizeHttpRequestParams to have a better logical flow and to handle partial request options (those without protocol and hostname, i.e. from supertest requests).
  • Added unit test for normalizeHttpRequestParams

GitHub

@kettanaito kettanaito force-pushed the 19-socket-set-no-delay branch 2 times, most recently from f7c4df0 to 3edfdba Compare June 12, 2020 18:23
@kettanaito kettanaito force-pushed the 19-socket-set-no-delay branch from 3edfdba to e21f484 Compare June 12, 2020 18:25
@kettanaito
Copy link
Member Author

Experiencing flaky tests after structuring interception/response tests to be flat. Area of affect seems to be random. Trying to run jest --no-cache --runInBand to prevent any persistent state between tests.

@kettanaito kettanaito force-pushed the 19-socket-set-no-delay branch from 337b492 to e88c118 Compare June 13, 2020 09:41
@kettanaito
Copy link
Member Author

Flaky tests behavior was solved by running tests with --no-cache --runInBand Jest CLI options.

@kettanaito kettanaito merged commit 2c97a07 into master Jun 13, 2020
@kettanaito kettanaito deleted the 19-socket-set-no-delay branch June 13, 2020 09:42
@kettanaito kettanaito mentioned this pull request Jun 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Socket.setNoDelay: TypeError: Cannot read property 'apply' of undefined
1 participant
@kettanaito