feat: use picocolors instead of chalk
#2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
changed the title
picocolors instead of chalk
kettanaito
previously approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Hi, @Namchee. Thanks for proposing this! Looks good to me. Need to try this out locally to see that the colors function as expected. We don't have tests asserting colors of the output, afaik.
kettanaito
previously approved these changes
Dec 16, 2024
kettanaito
force-pushed
the
chore/migrate-chalk-to-picocolors
branch
from
1577ebd to
4868fa9
Compare
|
Finally fixed the failing E2E test by stripping the color tokens from the stdout/stderr during the assertions. This is ready for merge! 🚀 |
kettanaito
approved these changes
Dec 16, 2024
|
Welcome to contributors, @Namchee! Thanks for making MSW more lightweight. |
Released: v2.7.0 🎉This has been released in v2.7.0! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request replaces
chalkwithpicocolors, a smaller alternative with the same API that will reduce install size from 97kB to 6.4kBMore benchmarks on picocolors