libBlocksRuntime: Mark public symbols with dllexport #19777
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions which are marked with
BLOCK_EXPORT
are supposed to be externally visible, but miss the__attribute__((dllexport))
attribute. As a result, they are not exported from a .dll when compiled with clang.Additionally, methods marked with
__attribute__((dllexport))
cannot have the__attribute__((weak))
attribute applied to them, so make that conditional on being compiled for non-Windows platforms.Together with #19767, this helps compiling Objective C code on MinGW using the clang compiler.