Add trash

[Athozus]

This is a PR for adding trash system to mail, as requested by some players across servers (and myself too). This would complete #38 if merged.

• Add trash tab on main UI
• Permit trash a mail
• Enable or disable trashing via settings (can be still permanent delete)
• Permit restore mails in there old boxes

Some interesting infos :

• It adds a previous_boxes value to mail while they're in trash (removed after restoring)
• To obtain the previous one, a new function called mail.get_message_boxes(playername, msg_id) returns a list of boxes like {"inbox", "outbox"}
• A parameter delete_in_trash has been added to mail.delete_mail() to avoid trash delete when you just moved the mails.

I'm waiting for your answers to know if you might fix things. Actually tried, it works without crash.

Some screenshots below :

1. Some mails in my trash
2. A mail has been restored
3. Setting is enabled

[BuckarooBanzay]

didn't test, only had one issue, otherwise looks good i think 👍

[S-S-X]

Didn't test but also didn't spot any obvious issues.

Minor thing but for UI I think it would be better to hide trash tab completely if trash is disabled. Doing so would allow having cleaner main user interface for those who do not want that functionality.

[Athozus]

Minor thing but for UI I think it would be better to hide trash tab completely if trash is disabled. Doing so would allow having cleaner main user interface for those who do not want that functionality.

Hi, I'm not sure with that one because the trash is still there when you disable auto-trashing. Maybe a Trash button, separated from the Delete one, would be better ? And if the autotrash is enabled, then Trash and Delete button do the same thing.

[Athozus]

You know what, maybe we should merge know and change minor things based on user experience ?

[S-S-X]

Could be another button, but that suggestion is just based on my personal preference: to not see those buttons/tabs at all because there's a lot of stuff anyway and I would not need those for anything. From this view point adding another button would be even worse.

It is debatable if hiding existing message is bad or good thing, some could actually like that feature. But anyway this isn't really useful reasoning for doing so (but also not against doing so), just a note that in the end hiding existing(mails in trash storage) things might actually be usable feature.

[Athozus]

Following your suggestions, I merge