Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for bugs #135 and #136 #137

Merged
merged 2 commits into from
Feb 1, 2024
Merged

fix for bugs #135 and #136 #137

merged 2 commits into from
Feb 1, 2024

Conversation

singularis-mzf
Copy link
Contributor

This is my fix for the bugs. I tested that the bugs were fixed by this, but I didn't run designed tests for the mod.

S-S-X
S-S-X reviewed Jan 28, 2024
View reviewed changes
ui/compose.lua Outdated Show resolved Hide resolved
S-S-X
S-S-X approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@S-S-X S-S-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not really know code base well enough to be sure but still I believe for mail.show_compose this is correct behavior: generate new id for selection if no id available yet.

This is for new mail right? And existing id is for drafts?

This was linked to issues Jan 28, 2024
Message ID mess #135
Closed
A maillist is deleted instead of renamed #136
Closed
@Athozus Athozus added this to the 1.4.0 milestone Jan 28, 2024
Athozus
Athozus approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@Athozus Athozus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Didn't tested but 99% seems ok according to my knowledge of the process of this file.

@Athozus
Copy link
Member

Athozus commented Jan 28, 2024

I do not really know code base well enough to be sure but still I believe for mail.show_compose this is correct behavior: generate new id for selection if no id available yet.

This is for new mail right? And existing id is for drafts?

Yes, the thing is to distinguish previously blank messages and draft messages being sent.

@Athozus Athozus merged commit fcca0b7 into mt-mods:master Feb 1, 2024
10 checks passed
@Athozus Athozus added the Bug Something isn't working label Mar 22, 2024
@Athozus Athozus mentioned this pull request Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-S-X S-S-X S-S-X approved these changes

@Athozus Athozus Athozus approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

A maillist is deleted instead of renamed Message ID mess
3 participants
@singularis-mzf @Athozus @S-S-X