-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings #85
Add settings #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't test but looks good 👍 (thanks for addressing the table/list thing)
I have a quick issue reported by @Bastrabun. On some servers, when you press escape, it is still there. It is due to the |
you could use the |
Yeah at first I would like to do that but I think that checkboxes can't give their values when there aren't toggled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but also didn't actually test anything.
Nope, I have to find a way to get checkboxes values while pressing |
This one is fixed, I merge so (I used |
This is a merge request, according to #51, to add settings to the mod. Currently there are not the sounds/trash settings like I did on the issue, cause it's not yet implemented (will be in few days).
Some interesting infos :
entry.settings
with following syntax :Closes #51