Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal contains several improvements:
FindBookQuery
strictly returns aBook
instance; otherwise, aMissingBookException
is thrown.MissingBookException
is mapped to return a 404 status code, so a clear exception message is now displayed.CommandHandlerInterface
with theAsCommandHandler
attribute, andQueryHandlerInterface
with theAsQueryHandler
attribute. The reason behind this is the fact that these interfaces have no contract; they are used as metadata to configure the messenger handler only. So, in this case, we can now use attributes instead as they are intended for that purpose.