-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.4.0 Update #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MtconnectModel is the intended entry point into the MTConnect SysML model. - Successful build
- Fixed DefaultValue - Fixed Generalization - Added property inheritance - Fixed naming to match SysML
- Added Enums to Packages - Removed unnecessary XML summary prefixes (///)
- Added Profile Packages to root MtconnectModel
Attempting to override the IClass.Properties with the custom PropertyList
Changed property name/type to reflect observation type categories
- Added ReferenceId to IEnum - Added HelpUrl property and constant to IClass, IEnum, and IPackage - Refactored "normative remarks" in XML summary.
- Added help url to observation type in navigation extensions
- Changed comparison of Observation Type names ordinal with a removal of '_' characters on both sides between IClass and IEnum comparisons
- Used the Example transpiler to generate files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump update
MtconnectTranspiler
andMtconnectTranspiler.CodeGenerators.ScribanTemplates
.This update features a complete redesign of the C# library by moving away from a simple extension to the Scriban template into a fully documented reflection of the MTConnect Standard. The generated C# code from the example transpiler yields fully documented classes that represent the SysML package, class, and enum structures in C#.
These changes are in response to common feedback that the
XmiDocument
from theMtconnectTranspiler
is difficult to navigate and requires advanced knowledge of not only the MTConnect standard, but the underlying XMI structure as well. The new C# library should eliminate the need to understand the XMI structure and reduce required understanding of the structure of the MTConnect standard.