-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature account random background #1047
Feature account random background #1047
Conversation
Also, to respond to Issue #70 |
@domtancredi can you resolve the conflicts so I can try to move this forward with Minh? |
"My Account" is visible in two places, in top navbar and in the user dropdown menu. What's the reasoning behind this? |
Easy accessibility. We can remove it from either location. I suggest dropping from the dropdown menu until the top nav becomes too big |
What would it take to get this updated to merge with the current code? Any chance of screenshots? |
Ok, this branch is updated to latest on master. Screenshot: http://puu.sh/q4HCO/a9ebba9e4c.png It could use some testing, and some TLC on layout, however this is the baseline for a "my account" section of the site. |
@mtgred I'd like to see this merged to get a foundation going for further development on profile and friend-related features. @domtancredi, can you add a "Change" link next to the Avatar on the profile page that links to http://www.jinteki.net/help#avatar? |
Can it also be made to modify the email address associated with the account? There's at least 1 open issue about that request. |
@nealterrell will add the "Change" link to link out High-level steps:
Up until step 4, you can "drop out" of the process and still retain your existing email address |
Added an Account View, for managing the user's account + profile.
Added navigation to the view
Added updating the background image (visible in the gameboard when playing or spectating: had to update the opacity 1 instead of 0.7)
Could use some code review and possible refactoring