Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature account random background #1047

Merged
merged 11 commits into from
Dec 5, 2016

Conversation

domtancredi
Copy link
Contributor

Added an Account View, for managing the user's account + profile.
Added navigation to the view
Added updating the background image (visible in the gameboard when playing or spectating: had to update the opacity 1 instead of 0.7)

Could use some code review and possible refactoring

@domtancredi
Copy link
Contributor Author

Also, to respond to Issue #70

@nealterrell
Copy link
Collaborator

@domtancredi can you resolve the conflicts so I can try to move this forward with Minh?

@zaroth
Copy link
Collaborator

zaroth commented Feb 16, 2016

"My Account" is visible in two places, in top navbar and in the user dropdown menu. What's the reasoning behind this?

@domtancredi
Copy link
Contributor Author

Easy accessibility. We can remove it from either location. I suggest dropping from the dropdown menu until the top nav becomes too big

@JoelCFC25
Copy link
Collaborator

What would it take to get this updated to merge with the current code? Any chance of screenshots?

@domtancredi
Copy link
Contributor Author

Ok, this branch is updated to latest on master.

Screenshot: http://puu.sh/q4HCO/a9ebba9e4c.png

It could use some testing, and some TLC on layout, however this is the baseline for a "my account" section of the site.

@nealterrell
Copy link
Collaborator

@mtgred I'd like to see this merged to get a foundation going for further development on profile and friend-related features. @domtancredi, can you add a "Change" link next to the Avatar on the profile page that links to http://www.jinteki.net/help#avatar?

@JoelCFC25
Copy link
Collaborator

Can it also be made to modify the email address associated with the account? There's at least 1 open issue about that request.

@domtancredi
Copy link
Contributor Author

@nealterrell will add the "Change" link to link out
@JoelCFC25 yes, though we should step through the business logic for this, as it is entirely custom

High-level steps:

  1. update your profile with a new email address,
  2. send a "new confirmation" to that address,
  3. confirm that address from a link,
  4. finalize the "changed address" in the database with the new address (overwrite the old address)

Up until step 4, you can "drop out" of the process and still retain your existing email address

@mtgred mtgred merged commit f1a33f8 into mtgred:master Dec 5, 2016
@domtancredi domtancredi deleted the feature-account-random-background branch September 23, 2017 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants