Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up annotation processing: migrate Room kapt->ksp #273

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

juleskers
Copy link
Contributor

@juleskers juleskers commented Feb 6, 2024

hi @mueller-ma ,

Thanks for the great app, I've been using it happily on my phone these last years.

I'm playing with the code to see if I can (eventually, don't get your hopes up), do something about proper multi-sim, parallel tracker support.

In the meantime, just to get my feet wet, here is an unblock for the current dependabot build failures (#271).

While doing that, my IDE told me that "ksp" is faster than kapt for annotations, so I migrated that as well.

Hope this helps!

@mueller-ma
Copy link
Owner

Thanks for this PR. I update Gradle in a new PR (#274). Can you rebase this PR on main?

@juleskers
Copy link
Contributor Author

Ha, I was afraid that might happen.
Between the time I pulled my fork and opened the PR, I already had to rebase on top of the dependabot updates you just merged, which I also had in here originally 😅

I'll do the rebase, but I'm on mobile now just before bedtime, so it'll have to wait until tomorrow at the earliest.

@juleskers juleskers changed the title Gradle 8.6 to unblock dependabot; annotation processing kapt->ksp speed up annotation processing: migrate Room kapt->ksp Feb 7, 2024
@juleskers
Copy link
Contributor Author

Rebase done!

Not much remains of the original dependency bumps.

I'm sorry that our workstreams crossed. I'd have loved to save you some more work ❤️

Anyways, the annotation-speedup should still be valuable.

@mueller-ma
Copy link
Owner

FYI: I'll test Renovate Bot on a different project, because it can update gradlew automatically: mueller-ma/Coffee#309

@mueller-ma mueller-ma enabled auto-merge (squash) February 7, 2024 16:46
@mueller-ma mueller-ma merged commit 3021e05 into mueller-ma:main Feb 7, 2024
2 checks passed
@juleskers juleskers deleted the tooling-update branch February 7, 2024 17:01
@juleskers
Copy link
Contributor Author

juleskers commented Feb 7, 2024

Thanks for the quotation fix! I should really look into configuring IntelliJ for that, it's not the first time it did this to me. (If I recall correctly, it's something about string interpolation, only in double quotes)

Renovate looks really cool! We use dependabot in our other project ( https://github.com/nicolasbrailo/PianOli ), but I'll be observing how renovate works for you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants