-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speed up annotation processing: migrate Room kapt
->ksp
#273
Conversation
Thanks for this PR. I update Gradle in a new PR (#274). Can you rebase this PR on |
Ha, I was afraid that might happen. I'll do the rebase, but I'm on mobile now just before bedtime, so it'll have to wait until tomorrow at the earliest. |
e1b2246
to
7d060b4
Compare
kapt
->ksp
Rebase done! Not much remains of the original dependency bumps. I'm sorry that our workstreams crossed. I'd have loved to save you some more work ❤️ Anyways, the annotation-speedup should still be valuable. |
FYI: I'll test Renovate Bot on a different project, because it can update gradlew automatically: mueller-ma/Coffee#309 |
Thanks for the quotation fix! I should really look into configuring IntelliJ for that, it's not the first time it did this to me. (If I recall correctly, it's something about string interpolation, only in double quotes) Renovate looks really cool! We use dependabot in our other project ( https://github.com/nicolasbrailo/PianOli ), but I'll be observing how renovate works for you ❤️ |
hi @mueller-ma ,
Thanks for the great app, I've been using it happily on my phone these last years.
I'm playing with the code to see if I can (eventually, don't get your hopes up), do something about proper multi-sim, parallel tracker support.
In the meantime, just to get my feet wet, here is an unblock for the current dependabot build failures (#271).
While doing that, my IDE told me that "ksp" is faster than kapt for annotations, so I migrated that as well.
Hope this helps!