Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure: Fixes #11 #42

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

Techassi
Copy link

@Techassi Techassi commented Apr 1, 2022

This PR fixes / extends #11 and implements the proposed changes by @muesli.

This also adds one new template helper: toUpper, which uppercases a string.

@Techassi
Copy link
Author

Techassi commented Apr 9, 2022

Any update on this?

@muesli
Copy link
Owner

muesli commented Apr 9, 2022

Appreciate the effort and it's certainly moving in the right direction, but I don't think we should introduce a generic pkg directory. There ought to be a better name 😄

Also, instead of deleting goodreads.go and replacing it with gr.go, please use git mv to preserve its history. This also makes it easier to review what/if content in these files changed in this PR. If you need help cleaning this up in this branch, I'm happy to help out. Just let me know!

@Techassi
Copy link
Author

Thank you for your feedback :)

Maybe a better name for pkg is internal as we don't really want to share the code with other programs.

I will also update the branch to include the history of goodreads.go / gr.go. Is there any particular reason we want to preserve the history of this file other than a better diff? Also are there any other files you want me to preserve the history from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants