Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added light/dark mode and improved ui #738

Merged
merged 7 commits into from
Dec 30, 2024
Merged

added light/dark mode and improved ui #738

merged 7 commits into from
Dec 30, 2024

Conversation

muhammad-fiaz
Copy link
Owner

  • overall new features and improved ui

@muhammad-fiaz muhammad-fiaz added documentation Improvements or additions to documentation enhancement New feature or request changes just some changes labels Dec 30, 2024
@muhammad-fiaz muhammad-fiaz self-assigned this Dec 30, 2024
Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
portfolio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 3:21pm

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 21 out of 36 changed files in this pull request and generated 1 comment.

Files not reviewed (15)
  • public/sitemap-0.xml: Language not supported
  • src/components/content/AboutMe.tsx: Language not supported
  • src/components/sections/HomeSection.tsx: Evaluated as low risk
  • next.config.ts: Evaluated as low risk
  • src/components/ui/ExternalLink.tsx: Evaluated as low risk
  • src/components/ui/Credits.tsx: Evaluated as low risk
  • src/components/ui/AuthAvatar.tsx: Evaluated as low risk
  • src/components/sections/ProjectsSection.tsx: Evaluated as low risk
  • README.md: Evaluated as low risk
  • src/components/ui/BackToTopButton.tsx: Evaluated as low risk
  • src/components/sections/AboutSection.tsx: Evaluated as low risk
  • src/components/sections/BlogSection.tsx: Evaluated as low risk
  • pages/api/fetch-projects.ts: Evaluated as low risk
  • src/components/content/CardBlog.tsx: Evaluated as low risk
  • src/components/content/TimeLineExp.tsx: Evaluated as low risk
Comments suppressed due to low confidence (3)

pages/api/fetchRSS.ts:21

  • Consider using more specific types for the 'req' and 'res' parameters to improve type safety.
req: { method: string }, res: { status: (statusCode: number) => any; json: (data: any) => void }

pages/api/fetchRSS.ts:40

  • [nitpick] Defaulting 'guid', 'title', 'link', and 'contentSnippet' to empty strings might hide potential issues with missing data. Consider logging a warning if any of these fields are missing.
guid: item.guid || '',

src/app/layout.tsx:16

  • Ensure that the BackToTopButton is correctly imported in the layout.tsx file.
import BackToTopButton from '@/src/components/ui/BackToTopButton';


res.status(200).json({ items: blogs });
} catch (error) {
console.error('Error fetching RSS feed:', error);
Copy link
Preview

Copilot AI Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message 'Error fetching RSS feed' is too generic. Consider including more details in the error message to aid in debugging.

Suggested change
console.error('Error fetching RSS feed:', error);
res.status(500).json({ message: `Error fetching RSS feed: ${error.message}` });

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@muhammad-fiaz muhammad-fiaz merged commit 6a59223 into main Dec 30, 2024
7 of 8 checks passed
@muhammad-fiaz muhammad-fiaz deleted the dev branch December 30, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes just some changes documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant