-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color palette blueGrey A100 sample documentation #26006
Comments
Interesting:
So it's a 4 years old decision #6548. Ok, happy to update the demos in the docs. Looks like an easy one: diff --git a/docs/src/pages/customization/color/Color.js b/docs/src/pages/customization/color/Color.js
index 4a040b296a..02454d0c4d 100644
--- a/docs/src/pages/customization/color/Color.js
+++ b/docs/src/pages/customization/color/Color.js
@@ -20,8 +20,10 @@ const mainColors = [
'Amber',
'Orange',
'Deep Orange',
+ 'Brown',
+ 'Grey',
+ 'Blue Grey',
];
-const neutralColors = ['Brown', 'Grey', 'Blue Grey'];
const mainPalette = [50, 100, 200, 300, 400, 500, 600, 700, 800, 900];
const altPalette = ['A100', 'A200', 'A400', 'A700'];
@@ -131,14 +133,6 @@ function Color(props) {
showAltPalette: true,
}),
)}
- {neutralColors.map((neutralColor) =>
- getColorGroup({
- classes,
- theme,
- color: neutralColor,
- showAltPalette: false,
- }),
- )}
</div>
);
}
diff --git a/packages/material-ui/src/colors/grey.d.ts b/packages/material-ui/src/colors/grey.d.ts
index 7c8c0f2ed3..62b0e6a707 100644
--- a/packages/material-ui/src/colors/grey.d.ts
+++ b/packages/material-ui/src/colors/grey.d.ts
@@ -54,11 +54,11 @@ declare const grey: {
/**
* Preview: ![grey A400](https://material-ui.com/static/colors-preview/grey-A400-24x24.svg)
*/
- A400: '#303030';
+ A400: '#616161';
/**
* Preview: ![grey A700](https://material-ui.com/static/colors-preview/grey-A700-24x24.svg)
*/
- A700: '#616161';
+ A700: '#303030';
};
export default grey;
diff --git a/packages/material-ui/src/colors/grey.js b/packages/material-ui/src/colors/grey.js
index 7169551644..038768b0bc 100644
--- a/packages/material-ui/src/colors/grey.js
+++ b/packages/material-ui/src/colors/grey.js
@@ -11,8 +11,8 @@ const grey = {
900: '#212121',
A100: '#d5d5d5',
A200: '#aaaaaa',
- A400: '#303030',
- A700: '#616161',
+ A400: '#616161',
+ A700: '#303030',
};
export default grey; |
Hey, I would like to work on this. |
Should I make the changes as indicated in the diffs above? |
@oliviertassinari : So which way you go, you will take the same reference value P.s. What about a |
@Angelk90 I don't understand the questions. This seems off-topic. |
@anshuman9999 This would be a great starting point, yes. They you would need to make sure it's good enough to be merged (maybe there are no other changes required, maybe not). |
@oliviertassinari Alright, I'll try opening a PR for it. Thank You for your help! |
@oliviertassinari , @anshuman9999 : you should also check the colors like brown and grey. |
Current Behavior 😯
@oliviertassinari : Currently in the documentation there are the following colors for blueGrey:
But the following shades seem to be missing:
https://github.com/mui-org/material-ui/blob/33850e52ca32787fbc02b64d3225bac2d451612c/packages/material-ui/src/colors/blueGrey.d.ts#L49-L61
Expected Behavior 🤔
The following shades seem to be missing in the documentation for the following colors brown, gray, blueGrey.
Steps to Reproduce 🕹
The text was updated successfully, but these errors were encountered: