Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Document all the colors available #26015

Merged
merged 1 commit into from
Apr 28, 2021
Merged

[docs] Document all the colors available #26015

merged 1 commit into from
Apr 28, 2021

Conversation

pandeymangg
Copy link
Contributor

@pandeymangg pandeymangg commented Apr 28, 2021

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 28, 2021

Details of bundle changes

Generated by 🚫 dangerJS against 133ed2d

@oliviertassinari oliviertassinari changed the title [docs] Changed color pallet for neutral colors [docs] Document all the colors available Apr 28, 2021
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Apr 28, 2021
@oliviertassinari oliviertassinari merged commit 2c7d5fe into mui:next Apr 28, 2021
@oliviertassinari
Copy link
Member

@anshuman9999 It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@pandeymangg
Copy link
Contributor Author

@oliviertassinari Thank you so much for helping me out here!

@pandeymangg pandeymangg deleted the my-topic-branch branch April 29, 2021 04:30
@Angelk90
Copy link
Contributor

@oliviertassinari , @anshuman9999 :

Looking at the preview I saw that the gray colors of A100, A200, A400, A700 correspond with values of 100, 200, 400, 700.

Which instead happens in brown and blueGrey.

As you can see in the image those in the blue squares the values of A correspond you have values without A.

Instead the one in the red squares the values do not match.

I would like to understand why this choice, I have not found anything online.

Schermata 2021-04-29 alle 10 22 04

eps1lon pushed a commit to siriwatknp/material-ui that referenced this pull request Apr 29, 2021
@oliviertassinari
Copy link
Member

@Angelk90 You are right, it looks like we overlooked this. Do you want to do a follow-up with?

diff --git a/packages/material-ui/src/colors/grey.js b/packages/material-ui/src/colors/grey.js
index 038768b0bc..7c1cb9d013 100644
--- a/packages/material-ui/src/colors/grey.js
+++ b/packages/material-ui/src/colors/grey.js
@@ -9,10 +9,10 @@ const grey = {
   700: '#616161',
   800: '#424242',
   900: '#212121',
-  A100: '#d5d5d5',
-  A200: '#aaaaaa',
-  A400: '#616161',
-  A700: '#303030',
+  A100: '#f5f5f5',
+  A200: '#eeeeee',
+  A400: '#bdbdbd',
+  A700: '#616161',
 };

 export default grey;

siriwatknp added a commit that referenced this pull request May 12, 2021
* migrate to emotion

* make styleProps optional

* remove lint and add fn name

* use yearButton from styles

* revert types

* [docs] Document all the colors available (#26015)

* [Timeline] Add support for position override on items (#25974)

* [core] Remove deprecated innerRef prop (#26028)

[core] Remove deprecated innerRef prop (#26028)

* [theme] Rename `createMuiTheme` to `createTheme` (#25992)

* [pickers] Remove redundant aria-hidden (#26014)

* [internal][pickers] Remove unused styles (#26023)

* [pickers] Toggle mobile keyboard view in the same commit as the view changes (#26017)

* [DateRangePicker] Fix not being opened on click (#26016)

* Inline classes

* type -> interface

* sort asc

* default props are private

* remove uneccesary type casting

* follow convention

* trigger pipeline

Co-authored-by: Anshuman Pandey <[email protected]>
Co-authored-by: simonecervini <[email protected]>
Co-authored-by: Matheus Wichman <[email protected]>
Co-authored-by: Sebastian Silbermann <[email protected]>
Co-authored-by: Olivier Tassinari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color palette blueGrey A100 sample documentation
4 participants