-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[l10n] Improve Russian translation #18422
Conversation
Details of bundle changes.Comparing: 3772c19...0c03967
|
@gmltA Regarding the plural handling, could you update the |
@oliviertassinari roger that! |
About plural form it is a nice case. Our modules are separate esm bundles? If so we can use packages like this https://www.npmjs.com/package/plural-ru which will automatically resolve the plural form Also several changes. Cannot comment in code from new github app :( Строк на страницу: -> Строк на странице |
@dmtrKovalenko I had a thought about utilizing some third-party for this, but as @oliviertassinari mentioned, for now it is not something vital (literally one case in the whole repository). |
Awesome, thank you guys. |
This is a quick fix for Russian text lines in library localization.
However, there is an issue with declination. In Russian you can't simply add an ending to noun to make it plural (as in English). There are two different endings for plural nouns (and sometimes word alters a bit).
Example:
2-4 stars translates as 2-4 звезды, but 5, 6, 7... 20 stars will be звёзд. Then again 21 stars translates as 21 звезда.
Common solution here is to define function that takes three word forms and a number and returns suitable one.
Is it ok, if I put such function into
/utils
subfolder?Closes #18421