fix: Ensure keepMounted prop prevents hidden attribute for inline ele…

…ments
mui · Jan 13, 2025 · c09a5d9 · c09a5d9
1 parent 4d8f6a7
commit c09a5d9
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/packages/react/src/checkbox/indicator/CheckboxIndicator.tsx b/packages/react/src/checkbox/indicator/CheckboxIndicator.tsx
@@ -66,7 +66,7 @@ const CheckboxIndicator = React.forwardRef(function CheckboxIndicator(
     className,
     customStyleHookMapping,
     extraProps: {
-      hidden: !mounted,
+      hidden: !keepMounted && !mounted,
       ...otherProps,
     },
   });

diff --git a/packages/react/src/menu/checkbox-item-indicator/MenuCheckboxItemIndicator.tsx b/packages/react/src/menu/checkbox-item-indicator/MenuCheckboxItemIndicator.tsx
@@ -33,9 +33,9 @@ const MenuCheckboxItemIndicator = React.forwardRef(function MenuCheckboxItemIndi
     (externalProps = {}) =>
       mergeReactProps(externalProps, {
         'aria-hidden': true,
-        hidden: !mounted,
+        hidden: !keepMounted && !mounted,
       }),
-    [mounted],
+    [keepMounted, mounted],
   );
 
   useAfterExitAnimation({

diff --git a/packages/react/src/menu/radio-item-indicator/MenuRadioItemIndicator.tsx b/packages/react/src/menu/radio-item-indicator/MenuRadioItemIndicator.tsx
@@ -33,9 +33,9 @@ const MenuRadioItemIndicator = React.forwardRef(function MenuRadioItemIndicator(
     (externalProps = {}) =>
       mergeReactProps(externalProps, {
         'aria-hidden': true,
-        hidden: !mounted,
+        hidden: !keepMounted && !mounted,
       }),
-    [mounted],
+    [keepMounted, mounted],
   );
 
   useAfterExitAnimation({

diff --git a/packages/react/src/radio/indicator/RadioIndicator.tsx b/packages/react/src/radio/indicator/RadioIndicator.tsx
@@ -44,7 +44,7 @@ const RadioIndicator = React.forwardRef(function RadioIndicator(
     className,
     state,
     extraProps: {
-      hidden: !mounted,
+      hidden: !keepMounted && !mounted,
       ...otherProps,
     },
     customStyleHookMapping,