Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu, Select] Trigger label prop appears to be unused #1072

Closed
vladmoroz opened this issue Dec 12, 2024 · 2 comments · Fixed by #1094
Closed

[Menu, Select] Trigger label prop appears to be unused #1072

vladmoroz opened this issue Dec 12, 2024 · 2 comments · Fixed by #1094
Labels
component: menu This is the name of the generic UI component, not the React module! component: select This is the name of the generic UI component, not the React module!

Comments

@vladmoroz
Copy link
Contributor

vladmoroz commented Dec 12, 2024

Not sure what the original purpose of the prop was, but it's not used in any way. Should we remove it?

https://github.com/mui/base-ui/blob/master/packages/react/src/select/trigger/SelectTrigger.tsx
https://github.com/mui/base-ui/blob/master/packages/react/src/menu/trigger/MenuTrigger.tsx

Search keywords:

@vladmoroz vladmoroz added component: select This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! labels Dec 12, 2024
@michaldudak
Copy link
Member

It seems that the only purpose of it was to prevent it from being applied to the rendered <button />. I don't remember why, though.

Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module! component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants