Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu, Select] Do not ignore the Trigger's label prop #1094

Merged
merged 1 commit into from
Dec 15, 2024
Merged

[Menu, Select] Do not ignore the Trigger's label prop #1094

merged 1 commit into from
Dec 15, 2024

Conversation

michaldudak
Copy link
Member

Fixes #1072

@michaldudak michaldudak added component: select This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! labels Dec 15, 2024
@mui-bot
Copy link

mui-bot commented Dec 15, 2024

Netlify deploy preview

https://deploy-preview-1094--base-ui.netlify.app/

Generated by 🚫 dangerJS against 6c95181

atomiks
atomiks approved these changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@atomiks atomiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title?

@michaldudak michaldudak changed the title [Menu, Select] Do not ignore the Trigger's title prop [Menu, Select] Do not ignore the Trigger's label prop Dec 15, 2024
@michaldudak
Copy link
Member Author

label, of course.

@michaldudak michaldudak merged commit 73c241f into mui:master Dec 15, 2024
25 checks passed
@michaldudak michaldudak deleted the menu-select-trigger-label branch December 15, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiks atomiks atomiks approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

Assignees
No one assigned
Labels
component: menu This is the name of the generic UI component, not the React module! component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Menu, Select] Trigger label prop appears to be unused
3 participants
@michaldudak @mui-bot @atomiks