[popups] onOpenChangeComplete prop
#1305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy preview |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
PR: out-of-date
atomiks
force-pushed
the
feat/onOpenChangeComplete
branch
from
05afb45 to
aec975d
Compare
atomiks
changed the title
onOpenChangeComplete prop
zannager
added
component: dialog
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: atomiks <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
mj12albert
reviewed
Jan 23, 2025
mj12albert
approved these changes
Jan 23, 2025
| * Calls the provided function when the CSS open animation or transition completes. | ||
| */ | ||
| export function useOpenChangeComplete(parameters: useOpenChangeComplete.Parameters) { | ||
| const { open, change = 'close', ref, onComplete: onCompleteParam } = parameters; |
There was a problem hiding this comment.
It may be a bit more readable if this change param didn't have a default, but it probably doesn't matter outside of looking at this code in Github
anyway I tested onOpenChangeComplete in a bunch of our hero demos and it works well (they all use CSS transitions) 👍
CC @michaldudak to review the implementation as well 🙏
There was a problem hiding this comment.
Was a small optimization since it's called in many of the root components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1208
New alternative to #1235 to support both symmetric open/close cases, which has a more intuitive API.
useAfterExitAnimationto support both open/close animationsonOpenChangeCompleteis called withopen: boolean