[Toolbar] Add Toolbar components #1349
Draft
+1,491
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mj12albert
force-pushed
the
feat/toolbar
branch
2 times, most recently
from
f2b6d91 to
9c3111f
Compare
4 tasks
mj12albert
force-pushed
the
feat/toolbar
branch
from
2901a4d to
61dc192
Compare
mj12albert
commented
Feb 3, 2025
| @@ -22,6 +23,8 @@ export function useButton(parameters: useButton.Parameters = {}): useButton.Retu | |||
| rootElementName: elementNameProp, | |||
| }); | |||
|
|
|||
| const isCompositeItem = useCompositeRootContext(true) !== undefined; | |||
There was a problem hiding this comment.
This is to work around using Select.Trigger as a composite item by letting CompositeItem's tabIndex override the internal one in useButton
Like Menu.Trigger, select trigger manually sets tabIndex to keep a consistent "trigger remains focused after a select/menu item is select" behavior across browsers (Safari on iPadOS and iOS): https://github.com/mui/base-ui/blob/master/packages/react/src/select/trigger/useSelectTrigger.ts#L80
mj12albert
force-pushed
the
feat/toolbar
branch
from
3fdc408 to
9408b1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://deploy-preview-1349--base-ui.netlify.app/experiments/toolbar
TODO
Component integrations
Closes #661