Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Pin pnpm's version #879

Merged
merged 3 commits into from
Nov 30, 2024
Merged

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Nov 27, 2024

I noticed some changes when running pnpm i/pnpm dedupe whe using a newer version of pnpm. Pinning the pnpm's version in the engines definition will eliminate this problem.

@mnajdova mnajdova added the core Infrastructure work going on behind the scenes label Nov 27, 2024
@mnajdova mnajdova changed the title [core] Run pnpm dedupe [core] Pin pnpm's version Nov 28, 2024
@mnajdova mnajdova marked this pull request as ready for review November 28, 2024 11:41
@mui-bot
Copy link

mui-bot commented Nov 28, 2024

Netlify deploy preview

https://deploy-preview-879--base-ui.netlify.app/

Generated by 🚫 dangerJS against 99ae606

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field's version was loosened in #529, but it appears that the lockfile can be different between minor versions, so we have to pin it.

Copy link
Contributor

@atomiks atomiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed this exact issue with dedupe, so pinning makes sense

@mnajdova mnajdova merged commit fd12afc into mui:master Nov 30, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants