-
Notifications
You must be signed in to change notification settings - Fork 831
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[core] Continue eslint sync with main repo (#2004)
- Loading branch information
1 parent
e33282a
commit 537dc6e
Showing
142 changed files
with
1,658 additions
and
1,345 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,43 +1,197 @@ | ||
| module.exports = { | ||
| parser: '@typescript-eslint/parser', | ||
| parserOptions: { | ||
| ecmaVersion: 6, | ||
| sourceType: 'module', | ||
| ecmaFeatures: { | ||
| jsx: true, | ||
| }, | ||
| root: true, // So parent files don't get applied | ||
| globals: { | ||
| preval: false, // Used in the documentation | ||
| }, | ||
| settings: { | ||
| react: { | ||
| version: 'detect', | ||
| }, | ||
| env: { | ||
| es6: true, | ||
| browser: true, | ||
| node: true, | ||
| jest: true, | ||
| }, | ||
| extends: [ | ||
| 'plugin:@typescript-eslint/recommended', | ||
| 'plugin:import/recommended', | ||
| 'plugin:import/typescript', | ||
| 'airbnb-typescript', | ||
| 'prettier', | ||
| 'prettier/react', | ||
| 'prettier/@typescript-eslint', | ||
| ], | ||
| plugins: ['react', 'react-hooks', 'pretty-imports', '@typescript-eslint'], | ||
| parser: '@typescript-eslint/parser', | ||
| parserOptions: { | ||
| ecmaVersion: 7, | ||
| }, | ||
| plugins: ['react-hooks', '@typescript-eslint'], | ||
| settings: { | ||
| 'import/resolver': { | ||
| node: { | ||
| extensions: ['.js', '.jsx', '.ts', '.tsx', '.json'], | ||
| }, | ||
| }, | ||
| }, | ||
| /** | ||
| * Sorted alphanumerically within each group. built-in and each plugin form | ||
| * their own groups. | ||
| */ | ||
| rules: { | ||
| '@typescript-eslint/explicit-function-return-type': 0, | ||
| '@typescript-eslint/explicit-member-accessibility': 0, | ||
| '@typescript-eslint/no-non-null-assertion': 0, | ||
| '@typescript-eslint/no-explicit-any': 0, | ||
| // in scripts and config files it's required to use dynamic require | ||
| '@typescript-eslint/no-var-requires': 0, | ||
| 'react/no-children-prop': 0, | ||
| 'react/jsx-uses-vars': 2, | ||
| 'react/jsx-uses-react': 2, | ||
| 'pretty-imports/sorted': 'warn', | ||
| '@typescript-eslint/no-use-before-define': 'warn', | ||
| 'consistent-this': ['error', 'self'], | ||
| // just as bad as "max components per file" | ||
| 'max-classes-per-file': 'off', | ||
| 'no-alert': 'error', // Too much interruptive | ||
| 'no-console': ['error', { allow: ['warn', 'error'] }], // Allow warn and error for production events | ||
| 'no-param-reassign': 'off', // It's fine. | ||
| 'no-constant-condition': 'error', | ||
| 'no-prototype-builtins': 'off', // Use the proptype inheritance chain | ||
| 'no-underscore-dangle': 'error', | ||
| 'nonblock-statement-body-position': 'error', | ||
| 'prefer-arrow-callback': ['error', { allowNamedFunctions: true }], | ||
| 'prefer-destructuring': 'off', // Destructuring harm grep potential. | ||
| '@typescript-eslint/dot-notation': 'off', // TODO performance consideration | ||
| '@typescript-eslint/no-implied-eval': 'off', // TODO performance consideration | ||
| '@typescript-eslint/no-throw-literal': 'off', // TODO performance consideration | ||
| 'import/named': 'off', // Not sure why it doesn't work | ||
| 'import/no-extraneous-dependencies': 'off', // Missing yarn workspace support | ||
| 'jsx-a11y/label-has-associated-control': 'off', // doesn't work? | ||
| 'jsx-a11y/no-autofocus': 'off', // We are a library, we need to support it too | ||
| 'react-hooks/exhaustive-deps': ['error', { additionalHooks: 'useEnhancedEffect' }], | ||
| 'react-hooks/rules-of-hooks': 'error', | ||
| 'react-hooks/exhaustive-deps': 'warn', | ||
| '@typescript-eslint/no-namespace': 'off', | ||
| '@typescript-eslint/no-empty-interface': 'off', | ||
| '@typescript-eslint/no-unused-vars': [ | ||
| 'error', | ||
| { vars: 'all', args: 'after-used', argsIgnorePattern: '^_', ignoreRestSiblings: true }, | ||
| 'react/destructuring-assignment': 'off', // It's fine. | ||
| 'react/forbid-prop-types': 'off', // Too strict, no time for that | ||
| 'react/jsx-curly-brace-presence': 'off', // broken | ||
| 'react/jsx-filename-extension': ['error', { extensions: ['.js', '.tsx'] }], // airbnb is using .jsx | ||
| 'react/jsx-fragments': ['error', 'element'], // Prefer <React.Fragment> over <>. | ||
| 'react/jsx-props-no-spreading': 'off', // We are a UI library. | ||
| 'react/no-array-index-key': 'off', // This rule is great for raising people awareness of what a key is and how it works. | ||
| 'react/no-danger': 'error', | ||
| 'react/no-direct-mutation-state': 'error', | ||
| 'react/no-find-dom-node': 'off', // Required for backward compatibility. TODO v5, drop | ||
| 'react/require-default-props': 'off', // Not always relevant | ||
| 'react/sort-prop-types': 'error', | ||
| // This depends entirely on what you're doing. There's no universal pattern | ||
| 'react/state-in-constructor': 'off', | ||
| // stylistic opinion. For conditional assignment we want it outside, otherwise as static | ||
| 'react/static-property-placement': 'off', | ||
|
|
||
| // TODO | ||
| 'import/no-cycle': 'warn', | ||
| 'import/prefer-default-export': 'off', | ||
| 'jsx-a11y/click-events-have-key-events': 'warn', | ||
| 'jsx-a11y/control-has-associated-label': 'warn', | ||
| 'jsx-a11y/no-static-element-interactions': 'warn', | ||
| 'no-nested-ternary': 'warn', | ||
| 'no-shadow': 'warn', | ||
| 'react/prop-types': 'off', // For public API | ||
| 'no-restricted-imports': [ | ||
| 'warn', | ||
| { | ||
| patterns: [ | ||
| '@material-ui/*/*/*', | ||
| '!@material-ui/core/test-utils/*', | ||
| '!@material-ui/utils/macros/*.macro', | ||
| ], | ||
| }, | ||
| ], | ||
| }, | ||
| overrides: [ | ||
| { | ||
| files: [ | ||
| '**/test-utils/**/*.js', | ||
| // matching the pattern of the test runner | ||
| '*.test.js', | ||
| ], | ||
| env: { | ||
| mocha: true, | ||
| }, | ||
| extends: ['plugin:mocha/recommended'], | ||
| rules: { | ||
| // does not work with wildcard imports. Mistakes will throw at runtime anyway | ||
| 'import/named': 'off', | ||
| 'no-restricted-imports': [ | ||
| 'error', | ||
| { | ||
| paths: [ | ||
| { | ||
| name: '@material-ui/core/test-utils', | ||
| importNames: ['createMount'], | ||
| message: | ||
| "Please use `import createMount from 'test/utils/createMount'` instead. `createMount` from /core has cleanup issues that require breaking changes.", | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
|
|
||
| // upgraded level from recommended | ||
| 'mocha/no-exclusive-tests': 'error', | ||
| 'mocha/no-skipped-tests': 'error', | ||
|
|
||
| // no rationale provided in /recommended | ||
| 'mocha/no-mocha-arrows': 'off', | ||
| // definitely a useful rule but too many false positives | ||
| // due to `describeConformance` | ||
| // "If you're using dynamically generated tests, you should disable this rule."" | ||
| 'mocha/no-setup-in-describe': 'off', | ||
| // `beforeEach` for a single case is optimized for change | ||
| // when we add a test we don't have to refactor the existing | ||
| // test to `beforeEach`. | ||
| // `beforeEach`+`afterEach` also means that the `beforeEach` | ||
| // is cleaned up in `afterEach` if the test causes a crash | ||
| 'mocha/no-hooks-for-single-case': 'off', | ||
|
|
||
| // disable eslint-plugin-jsx-a11y | ||
| // tests are not driven by assistive technology | ||
| // add `jsx-a11y` rules once you encounter them in tests | ||
| 'jsx-a11y/click-events-have-key-events': 'off', | ||
| 'jsx-a11y/control-has-associated-label': 'off', | ||
| 'jsx-a11y/iframe-has-title': 'off', | ||
| 'jsx-a11y/mouse-events-have-key-events': 'off', | ||
| 'jsx-a11y/no-noninteractive-tabindex': 'off', | ||
| 'jsx-a11y/no-static-element-interactions': 'off', | ||
| 'jsx-a11y/tabindex-no-positive': 'off', | ||
|
|
||
| // They are accessed to test custom validator implementation with PropTypes.checkPropTypes | ||
| 'react/forbid-foreign-prop-types': 'off', | ||
| // components that are defined in test are isolated enough | ||
| // that they don't need type-checking | ||
| 'react/prop-types': 'off', | ||
| }, | ||
| }, | ||
| { | ||
| files: ['docs/pages/**/*.js'], | ||
| rules: { | ||
| 'react/prop-types': 'off', | ||
| }, | ||
| }, | ||
| { | ||
| files: ['*.d.ts'], | ||
| rules: { | ||
| 'import/export': 'off', // Not sure why it doesn't work | ||
| }, | ||
| }, | ||
| { | ||
| files: ['*.spec.tsx', '*.spec.ts'], | ||
| rules: { | ||
| 'no-alert': 'off', | ||
| 'no-console': 'off', | ||
| 'no-empty-pattern': 'off', | ||
| 'no-lone-blocks': 'off', | ||
| 'no-shadow': 'off', | ||
| '@typescript-eslint/no-unused-expressions': 'off', | ||
| '@typescript-eslint/no-unused-vars': 'off', | ||
| '@typescript-eslint/no-use-before-define': 'off', | ||
| 'import/export': 'off', // Not sure why it doesn't work | ||
| 'import/prefer-default-export': 'off', | ||
| 'jsx-a11y/anchor-has-content': 'off', | ||
| 'jsx-a11y/anchor-is-valid': 'off', | ||
| 'jsx-a11y/tabindex-no-positive': 'off', | ||
| 'react/default-props-match-prop-types': 'off', | ||
| 'react/no-access-state-in-setstate': 'off', | ||
| 'react/no-unused-prop-types': 'off', | ||
| 'react/prefer-stateless-function': 'off', | ||
| 'react/prop-types': 'off', | ||
| 'react/require-default-props': 'off', | ||
| 'react/state-in-constructor': 'off', | ||
| 'react/static-property-placement': 'off', | ||
| }, | ||
| }, | ||
| ], | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
537dc6eThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to following URLs: