Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using memo with day components #1306

Closed
JamesM07 opened this issue Sep 9, 2019 · 0 comments · Fixed by #1602
Closed

Using memo with day components #1306

JamesM07 opened this issue Sep 9, 2019 · 0 comments · Fixed by #1602

Comments

@JamesM07
Copy link

JamesM07 commented Sep 9, 2019

I skip questions since I don't find them relevant, the only thing I need is a way to memoize day components which can extremely improve performance since it seems all days are getting re-rendered on every date change

dmtrKovalenko added a commit that referenced this issue Apr 9, 2020
* Make value for picker be a generic type

* Spread new props from passing to the dom element

* Split makePickerWith state hoc

* Better type inference for new makePickerWithWrapper

* Refactor and opimize shared prop types inference for pickers

* Rename eome type names and files

* Integrate validation back to usePickerState

* Remove DateRangePicker code

* Remove DateRangePickerUsage from index module

* Fix small linter and ts errors

* Fix build erros

* Run prettier manually

* Display calendars for date range

* [WiP] Work on displaying 2 calendars one by one

* WATER ON MY MAC

* Proper display days with margins with range highlights

* Fix unexpected month switchings

* Implement range preview

* Optimize rerenders of Day and DateRangeDay, closes #1306

* Fix crash and missing rerender

* Optimize rerendering performace of <Day />

* Use popper for date range wrapper

* Proper displaying values in DateRangePIckerInput

* Implement ClickAwayListner for popper wrapper

* Fix slide animation in date range picker

* Reorganize test folders

* Reorganize integration test folder

* Add focus managment logic

* Implement autoscrolling for switching between range start/end

* Improve date range picker with disabling min/max dates

* Update date-io adapter version to 2.5.0

* Do not display range preview on highlighted days

* Better focus and blur handling for popper

* Fix range preview border style

* Fix type erros

* Fix fantom borders appearing

* Better styling for popper and possibility to replace transition

* Fix missing mui globals

* Fix werid memoization issue in Safari

* Implement mobile version of DateRangePicker

* Better displaying in mobile mode

* Make possible to switch view by clicking on month and year header

* Properly spread props to mobile keyboard input view

* Fix ts erros and enable api generation

* Fix example ts-checks

* Fix ts error in ServerRerquest.example.jsx

* Fix error if mouning in open state

* Add props test for DateRangePickers

* Export responsive date range picker by default

* Add missing displayName to the ToolbarButton

* Small enhancmenets

* Fix inclusivity of range for non-datefns livs

* Fix ts error

* Remove fake data from range example

* Use tsx in date range picker examples

* Add `startText` and `endText` props

* Update material-ui and fix createSvgIcon import, closes #1619

* Use new TextField `focused` prop for highlighting

* Close picker after range selected

* Update jss version

* Add more date-range-manager tests

* More examples and possibility to change wrapper mode for static wrapper

* Fix ts wrapper props inferring

* Update lib/src/views/Calendar/CalendarView.tsx

Co-Authored-By: Olivier Tassinari <[email protected]>

* Update docs/pages/demo/daterangepicker/CalendarsDateRangePicker.example.tsx

Co-Authored-By: Olivier Tassinari <[email protected]>

* Update createSvgIcon imports

* Fix ts inferrence for static wrapper props

* Add missing props spreading

* Fix more build errors

* Update lib/src/__tests__/setup.js

Co-Authored-By: Olivier Tassinari <[email protected]>

* Address review

* forwardRef for DateRangePicker

Co-authored-by: Olivier Tassinari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants