Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isNull and parse is missing in utils.d.ts #381

Closed
Mario-Eis opened this issue May 2, 2018 · 1 comment
Closed

isNull and parse is missing in utils.d.ts #381

Mario-Eis opened this issue May 2, 2018 · 1 comment

Comments

@Mario-Eis
Copy link

Mario-Eis commented May 2, 2018 •
edited
Loading

Environment

Tech Version
material-ui-pickers rc7

Steps to reproduce

utils.isNull is called in DateTextField.js but it's not defined in utils.d.ts

// if null - do not show error
if (utils.isNull(value)) {
    return '';
}

typescript wont complain at compile time, but fails at runtime.
@Mario-Eis Mario-Eis changed the title isNull is missing in utils.d.ts isNull and parse is missing in utils.d.ts May 2, 2018
dmtrKovalenko added a commit that referenced this issue May 10, 2018
@dmtrKovalenko
[#381] Add missing typeing for isNull and parse methods
a2a8d2c
@dmtrKovalenko dmtrKovalenko mentioned this issue May 10, 2018
Merged
1 task
@dmtrKovalenko
Copy link
Member

Published in rc.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmtrKovalenko @Mario-Eis