Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.2.3 #1271

Merged
merged 14 commits into from
Aug 21, 2019
Merged

3.2.3 #1271

merged 14 commits into from
Aug 21, 2019

Conversation

dmtrKovalenko
Copy link
Member

This PR closes #

Description

dmtrKovalenko and others added 14 commits August 4, 2019 23:06
* Show DateIOType instead of any in prop types tables

* Update patrons list

* Remove unused filter
After #1236, a few imports were remaining, remove those imports.
Also use type `Omit` from typescript utility types. This will ensure
zero direct references to `@material-ui/core`.
* Refactor wrapping <Picker /> in state to be 1 component

* Fix incorrect outputted typescript definitions

* Fixed incorrect KeyboardDatePicker props output
* Open picker by space/enter click

* Change new prop name to not conflict with current onOpen

* Use only enter to open

* Fix comment
@cypress
Copy link

cypress bot commented Aug 21, 2019



Test summary

50 0 0 0


Run details

Project material-ui-pickers
Status Passed
Commit efe1544
Started Aug 21, 2019 6:46 AM
Ended Aug 21, 2019 6:46 AM
Duration 00:45 💡
OS Linux Debian - 8.11
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #1271 into master will decrease coverage by 0.5%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1271      +/-   ##
==========================================
- Coverage   94.13%   93.62%   -0.51%     
==========================================
  Files          56       55       -1     
  Lines        1415     1350      -65     
  Branches      200      199       -1     
==========================================
- Hits         1332     1264      -68     
- Misses         65       68       +3     
  Partials       18       18
Impacted Files Coverage Δ
lib/src/wrappers/InlineWrapper.tsx 100% <ø> (ø) ⬆️
lib/src/_shared/WithUtils.tsx 100% <ø> (ø) ⬆️
lib/src/wrappers/Wrapper.tsx 87.5% <ø> (ø) ⬆️
lib/src/views/Clock/ClockPointer.tsx 92% <ø> (ø) ⬆️
lib/src/_shared/hooks/useKeyboardPickerState.ts 84.61% <ø> (ø) ⬆️
lib/src/DateTimePicker/DateTimePicker.tsx 90.47% <100%> (+1.58%) ⬆️
lib/src/Picker/Picker.tsx 100% <100%> (ø) ⬆️
lib/src/DateTimePicker/DateTimePickerToolbar.tsx 91.66% <100%> (ø) ⬆️
lib/src/wrappers/StaticWrapper.tsx 62.5% <100%> (ø) ⬆️
lib/src/DatePicker/DatePicker.tsx 100% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b9b848...efe1544. Read the comment docs.

@dmtrKovalenko dmtrKovalenko merged commit ddddbd9 into master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants