Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle crashing of .scrollIntoView on Firefox 52-57 #1393

Merged
merged 2 commits into from
Nov 15, 2019

Conversation

dmtrKovalenko
Copy link
Member

This PR closes #1365

@cypress
Copy link

cypress bot commented Nov 15, 2019



Test summary

51 0 0 0


Run details

Project material-ui-pickers
Status Passed
Commit d20a8d8
Started Nov 15, 2019 8:39 PM
Ended Nov 15, 2019 8:40 PM
Duration 00:53 💡
OS Linux Debian - 8.11
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #1393 into next will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1393      +/-   ##
==========================================
- Coverage   93.63%   93.49%   -0.14%     
==========================================
  Files          55       55              
  Lines        1351     1353       +2     
  Branches      200      200              
==========================================
  Hits         1265     1265              
- Misses         67       69       +2     
  Partials       19       19
Impacted Files Coverage Δ
lib/src/views/Year/YearView.tsx 84.21% <0%> (-4.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de7c8e...d20a8d8. Read the comment docs.

@dmtrKovalenko dmtrKovalenko merged commit 66074f3 into next Nov 15, 2019
@dmtrKovalenko dmtrKovalenko deleted the bugfix/crash-scrollIntoView-firefox branch November 15, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant