Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not selectable last year #1848

Merged
merged 10 commits into from
Jun 2, 2020
Merged

Conversation

dmtrKovalenko
Copy link
Member

@dmtrKovalenko dmtrKovalenko commented May 31, 2020

This PR help with #1774

@vercel
Copy link

vercel bot commented May 31, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mui-org/material-ui-pickers/axiqwcbp4
✅ Preview: https://material-ui-pickers-git-bugfix-not-selectable-last-year.mui-org.now.sh

@cypress
Copy link

cypress bot commented May 31, 2020



Test summary

78 0 1 0


Run details

Project material-ui-pickers
Status Passed
Commit b975e7d
Started Jun 2, 2020 9:14 AM
Ended Jun 2, 2020 9:15 AM
Duration 01:12 💡
OS Linux Debian - 10.0
Browser Chrome 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Comment on lines +8 to +9
const render = createClientRender({ strict: false });
it('Allows to select edge years from list', () => {
Copy link
Member

@oliviertassinari oliviertassinari Jun 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const render = createClientRender({ strict: false });
it('Allows to select edge years from list', () => {
// StrictModeViolation: uses Grow
const render = createClientRender({ strict: false });
it('Should disable the year on the edge if it doesn`t fit to the current date', () => {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my gosh, just realize that this test will fail each year on January 1st. I hate writing tests for datepickers XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants