Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Sort props ASC #1928

Merged
merged 1 commit into from
Jun 25, 2020
Merged

[core] Sort props ASC #1928

merged 1 commit into from
Jun 25, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 23, 2020 •
edited
Loading

One step closer to solve #1631 and mui/material-ui#19706.

@vercel
Copy link

vercel bot commented Jun 23, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mui-org/material-ui-pickers/5ijlta85u
✅ Preview: https://material-ui-pickers-git-fork-oliviertassinari-sort-asc.mui-org.vercel.app

@cypress
Copy link

cypress bot commented Jun 23, 2020 •
edited
Loading


Test summary

75 • 0 • 3 • 0

Run details
Project material-ui-pickers
Status Passed
Commit 4ff5dfc
Started Jun 25, 2020 1:05 PM
Ended Jun 25, 2020 1:06 PM
Duration 01:29 💡
OS Linux Debian - 10.0
Browser Chrome 80

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

oliviertassinari
oliviertassinari commented Jun 23, 2020
View reviewed changes
lib/src/_shared/hooks/useIsLandscape.tsx
@@ -29,12 +29,15 @@ export function useIsLandscape(
getOrientation()
);

const eventHandler = React.useCallback(() => setOrientation(getOrientation()), []);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplification

@dmtrKovalenko
Copy link
Member

Do you make all this sortings manually? If so – we need some automate solution for that

@dmtrKovalenko dmtrKovalenko mentioned this pull request Jun 24, 2020
Merged
@oliviertassinari
Copy link
Member Author

We have a constraint on sorting the prop types, otherwise eslint crashes. It would be cool if we can extended this static analysis.

oliviertassinari
oliviertassinari commented Jun 24, 2020
View reviewed changes
lib/src/views/Calendar/SlideTransition.tsx
reduceAnimations,
slideDirection,
className = undefined,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove dead code.

@oliviertassinari oliviertassinari merged commit b470d65 into mui:next Jun 25, 2020
@oliviertassinari oliviertassinari deleted the sort-asc branch June 25, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmtrKovalenko dmtrKovalenko dmtrKovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviertassinari @dmtrKovalenko