Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun validation when maxDate or minDate props is changed #226

Merged
merged 1 commit into from
Feb 23, 2018

Conversation

alexander-morozov
Copy link
Contributor

@alexander-morozov alexander-morozov commented Feb 22, 2018

  • I have changed my target branch to develop 👊

Description

The problem is that when maxDate or minDate contains expression that can be changed independently from datepicker value, validation is not re-run and error message isn't show/hide.

@dmtrKovalenko dmtrKovalenko self-requested a review February 23, 2018 10:29
Copy link
Member

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for good improvement, but first change your target branch to develop, as in pull request template said. I will approve your PR then

@alexander-morozov alexander-morozov changed the base branch from master to develop February 23, 2018 11:22
@alexander-morozov
Copy link
Contributor Author

Done

@dmtrKovalenko
Copy link
Member

Thank you!
Welcome to our awesome contributors community :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants