Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fading animation on moving between hours & minutes clocks #304

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Add fading animation on moving between hours & minutes clocks #304

merged 1 commit into from
Mar 29, 2018

Conversation

dmtrKovalenko
Copy link
Member

  • I have changed my target branch to develop 👊

Description

To improve user experience and match material design guidelines I have added an animation for moving between the clocks with a help of material-ui's <Fade /> component

@dmtrKovalenko dmtrKovalenko added the enhancement New feature or request label Mar 27, 2018
@dmtrKovalenko dmtrKovalenko self-assigned this Mar 27, 2018
alitaheri
alitaheri approved these changes Mar 29, 2018
View reviewed changes
Copy link
Member

@alitaheri alitaheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks 👍 👍

@dmtrKovalenko dmtrKovalenko merged commit 39cfc61 into develop Mar 29, 2018
@dmtrKovalenko dmtrKovalenko deleted the fade-clock-animation branch April 4, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alitaheri alitaheri alitaheri approved these changes

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees

@dmtrKovalenko dmtrKovalenko

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmtrKovalenko @alitaheri