[codemod] Leave numeric arguments to breakpoints functions unchanged

- The codemod was previously changing numeric values to `undefined`
mui · Apr 23, 2022 · 32b72af · 32b72af
1 parent af81aae
commit 32b72af
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/packages/mui-codemod/src/v5.0.0/theme-breakpoints.js b/packages/mui-codemod/src/v5.0.0/theme-breakpoints.js
@@ -22,7 +22,10 @@ export default function transformer(file, api, options) {
     })
     .forEach((path) => {
       path.node.arguments.forEach((node) => {
-        node.value = map[node.value];
+        const replacementValue = map[node.value];
+        if (replacementValue !== undefined) {
+          node.value = replacementValue;
+        }
       });
     });
 
@@ -36,7 +39,10 @@ export default function transformer(file, api, options) {
     })
     .forEach((path) => {
       const node = path.node.arguments[1];
-      node.value = map[node.value];
+      const replacementValue = map[node.value];
+      if (replacementValue !== undefined) {
+        node.value = replacementValue;
+      }
     });
 
   return root.toSource(printOptions);

diff --git a/packages/mui-codemod/src/v5.0.0/theme-breakpoints.test/actual.js b/packages/mui-codemod/src/v5.0.0/theme-breakpoints.test/actual.js
@@ -1,4 +1,5 @@
 theme.breakpoints.down('sm')
 theme.breakpoints.down('xl')
+theme.breakpoints.down(360)
 theme.breakpoints.between('sm', 'md')
 theme.breakpoints.between('sm', 'xl')
diff --git a/packages/mui-codemod/src/v5.0.0/theme-breakpoints.test/expected.js b/packages/mui-codemod/src/v5.0.0/theme-breakpoints.test/expected.js
@@ -1,4 +1,5 @@
 theme.breakpoints.down('md')
 theme.breakpoints.down('xl')
+theme.breakpoints.down(360)
 theme.breakpoints.between('sm', 'lg')
 theme.breakpoints.between('sm', 'xl')