[core] Remove usage of deprecated .keyCode

mui · Sep 11, 2020 · 58a899e · 58a899e
1 parent ad558cb
commit 58a899e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/docs/src/modules/components/AppSearch.js b/docs/src/modules/components/AppSearch.js
@@ -123,12 +123,8 @@ export default function AppSearch() {
 
   React.useEffect(() => {
     const handleKeyDown = (nativeEvent) => {
-      // Use nativeEvent.keyCode to support IE 11
       if (
-        [
-          191, // '/'
-          83, // 's'
-        ].indexOf(nativeEvent.keyCode) !== -1 &&
+        ['/', 's'].indexOf(nativeEvent.key) !== -1 &&
         document.activeElement.nodeName === 'BODY' &&
         document.activeElement !== inputRef.current
       ) {

diff --git a/packages/material-ui/src/Unstable_TrapFocus/Unstable_TrapFocus.js b/packages/material-ui/src/Unstable_TrapFocus/Unstable_TrapFocus.js
@@ -151,8 +151,7 @@ function Unstable_TrapFocus(props) {
     };
 
     const loopFocus = (nativeEvent) => {
-      // 9 = Tab
-      if (disableEnforceFocus || !isEnabled() || nativeEvent.keyCode !== 9) {
+      if (disableEnforceFocus || !isEnabled() || nativeEvent.key !== 'Tab') {
         return;
       }
 

diff --git a/packages/material-ui/src/Unstable_TrapFocus/Unstable_TrapFocus.test.js b/packages/material-ui/src/Unstable_TrapFocus/Unstable_TrapFocus.test.js
@@ -106,17 +106,17 @@ describe('<TrapFocus />', () => {
     );
 
     fireEvent.keyDown(screen.getByTestId('modal'), {
-      keyCode: 13, // Enter
+      key: 'Enter',
     });
     fireEvent.keyDown(screen.getByTestId('modal'), {
-      keyCode: 9, // Tab
+      key: 'Tab',
     });
 
     expect(document.querySelector('[data-test="sentinelStart"]')).toHaveFocus();
 
     initialFocus.focus();
     fireEvent.keyDown(screen.getByTestId('modal'), {
-      keyCode: 9, // Tab
+      key: 'Tab',
       shiftKey: true,
     });