[test] Make tests oblivious to StrictMode (#26654)

mui · Jun 8, 2021 · a28a5e7 · a28a5e7
1 parent cf2f6fa
commit a28a5e7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/packages/material-ui/src/Popper/Popper.test.js b/packages/material-ui/src/Popper/Popper.test.js
@@ -1,6 +1,6 @@
 import * as React from 'react';
 import { expect } from 'chai';
-import { spy, useFakeTimers } from 'sinon';
+import { useFakeTimers } from 'sinon';
 import PropTypes from 'prop-types';
 import {
   createMount,
@@ -44,17 +44,15 @@ describe('<Popper />', () => {
 
   describe('prop: placement', () => {
     it('should have top placement', () => {
-      const renderSpy = spy();
       render(
         <Popper {...defaultProps} placement="top">
           {({ placement }) => {
-            renderSpy(placement);
-            return null;
+            return <span data-testid="renderSpy" data-placement={placement} />;
           }}
         </Popper>,
       );
-      expect(renderSpy.callCount).to.equal(2); // strict mode renders twice
-      expect(renderSpy.args[0][0]).to.equal('top');
+
+      expect(screen.getByTestId('renderSpy')).to.have.attribute('data-placement', 'top');
     });
 
     [

diff --git a/packages/material-ui/src/TextareaAutosize/TextareaAutosize.test.js b/packages/material-ui/src/TextareaAutosize/TextareaAutosize.test.js
@@ -280,7 +280,7 @@ describe('<TextareaAutosize />', () => {
           scrollHeight: 100,
           lineHeight: () => {
             index += 1;
-            return 15 + index;
+            return index;
           },
         });
 

diff --git a/test/utils/mochaHooks.test.js b/test/utils/mochaHooks.test.js
@@ -46,7 +46,8 @@ describe('mochaHooks', () => {
 
     describe('dedupes missing act() warnings by component', () => {
       const mochaHooks = createMochaHooks(Mocha);
-      const render = createClientRender();
+      // missing act warnings only happen in StrictMode
+      const render = createClientRender({ strict: true });
 
       beforeEach(function beforeEachHook() {
         mochaHooks.beforeAll.forEach((beforeAllMochaHook) => {