[code-infra] Break package dependency cycle between @mui/material and…

… @mui/icons-material (#40400)
mui · Jan 2, 2024 · ad912d6 · ad912d6
1 parent 8837023
commit ad912d6
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 10 deletions.
diff --git a/packages/mui-material/package.json b/packages/mui-material/package.json
@@ -58,7 +58,6 @@
   "devDependencies": {
     "@mui-internal/babel-macros": "^1.0.0",
     "@mui-internal/test-utils": "^1.0.0",
-    "@mui/icons-material": "^5.15.2",
     "@mui/lab": "5.0.0-alpha.158",
     "@popperjs/core": "^2.11.8",
     "@rollup/plugin-replace": "^5.0.5",

diff --git a/packages/mui-material/src/TabScrollButton/TabScrollButton.test.js b/packages/mui-material/src/TabScrollButton/TabScrollButton.test.js
@@ -1,9 +1,11 @@
 import * as React from 'react';
 import { expect } from 'chai';
 import { createRenderer, describeConformance } from '@mui-internal/test-utils';
-import ArrowBackIcon from '@mui/icons-material/ArrowBack';
-import ArrowForwardIcon from '@mui/icons-material/ArrowForward';
 import TabScrollButton, { tabScrollButtonClasses as classes } from '@mui/material/TabScrollButton';
+import { createSvgIcon } from '@mui/material/utils';
+
+const ArrowBackIcon = createSvgIcon(<path d="M3 3h18v18H3z" />, 'ArrowBack');
+const ArrowForwardIcon = createSvgIcon(<path d="M3 3h18v18H3z" />, 'ArrowForward');
 
 describe('<TabScrollButton />', () => {
   const defaultProps = {

diff --git a/packages/mui-material/src/TablePagination/TablePagination.test.js b/packages/mui-material/src/TablePagination/TablePagination.test.js
@@ -12,10 +12,18 @@ import { outlinedInputClasses } from '@mui/material/OutlinedInput';
 import { filledInputClasses } from '@mui/material/FilledInput';
 import IconButton, { iconButtonClasses } from '@mui/material/IconButton';
 import { svgIconClasses } from '@mui/material/SvgIcon';
-import ArrowBackIcon from '@mui/icons-material/ArrowBack';
-import ArrowForwardIcon from '@mui/icons-material/ArrowForward';
-import KeyboardDoubleArrowLeftRoundedIcon from '@mui/icons-material/KeyboardDoubleArrowLeftRounded';
-import KeyboardDoubleArrowRightRoundedIcon from '@mui/icons-material/KeyboardDoubleArrowRightRounded';
+import { createSvgIcon } from '@mui/material/utils';
+
+const ArrowBackIcon = createSvgIcon(<path d="M3 3h18v18H3z" />, 'ArrowBack');
+const ArrowForwardIcon = createSvgIcon(<path d="M3 3h18v18H3z" />, 'ArrowForward');
+const KeyboardDoubleArrowLeftRoundedIcon = createSvgIcon(
+  <path d="M3 3h18v18H3z" />,
+  'KeyboardDoubleArrowLeftRounded',
+);
+const KeyboardDoubleArrowRightRoundedIcon = createSvgIcon(
+  <path d="M3 3h18v18H3z" />,
+  'KeyboardDoubleArrowRightRounded',
+);
 
 describe('<TablePagination />', () => {
   const noop = () => {};

diff --git a/packages/mui-material/src/TableSortLabel/TableSortLabel.test.js b/packages/mui-material/src/TableSortLabel/TableSortLabel.test.js
@@ -1,9 +1,11 @@
 import * as React from 'react';
 import { expect } from 'chai';
 import { createRenderer, describeConformance } from '@mui-internal/test-utils';
-import SortIcon from '@mui/icons-material/Sort';
 import TableSortLabel, { tableSortLabelClasses as classes } from '@mui/material/TableSortLabel';
 import ButtonBase from '@mui/material/ButtonBase';
+import { createSvgIcon } from '@mui/material/utils';
+
+const SortIcon = createSvgIcon(<path d="M3 3h18v18H3z" />, 'Sort');
 
 describe('<TableSortLabel />', () => {
   const { render } = createRenderer();

diff --git a/packages/mui-material/src/Tabs/Tabs.test.js b/packages/mui-material/src/Tabs/Tabs.test.js
@@ -10,14 +10,16 @@ import {
   strictModeDoubleLoggingSuppressed,
   waitFor,
 } from '@mui-internal/test-utils';
-import ArrowBackIcon from '@mui/icons-material/ArrowBack';
-import ArrowForwardIcon from '@mui/icons-material/ArrowForward';
 import Tab from '@mui/material/Tab';
 import Tabs, { tabsClasses as classes } from '@mui/material/Tabs';
 import { svgIconClasses } from '@mui/material/SvgIcon';
 import { createTheme, ThemeProvider } from '@mui/material/styles';
+import { createSvgIcon } from '@mui/material/utils';
 import capitalize from '../utils/capitalize';
 
+const ArrowBackIcon = createSvgIcon(<path d="M3 3h18v18H3z" />, 'ArrowBack');
+const ArrowForwardIcon = createSvgIcon(<path d="M3 3h18v18H3z" />, 'ArrowForward');
+
 function findScrollButton(container, direction) {
   return container.querySelector(`svg[data-testid="KeyboardArrow${capitalize(direction)}Icon"]`);
 }