Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SpeedDial] Add an option to make actions tooltip always visible #11088

Closed
vudzero opened this issue Apr 21, 2018 · 3 comments
Closed

[SpeedDial] Add an option to make actions tooltip always visible #11088

vudzero opened this issue Apr 21, 2018 · 3 comments
Labels
component: speed dial This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@vudzero
Copy link

vudzero commented Apr 21, 2018

Hi,

It would be nice if we could have the option to have speedDial actions buttons always show their tooltip. As it is, it's impossible to see the tooltip on mobile because of the mouseover requirements.

Thanks
@vudzero vudzero changed the title [SpeedDial] Add an option to make tooltip always visible [SpeedDial] Add an option to make actions tooltip always visible Apr 21, 2018
@oliviertassinari oliviertassinari added package: lab Specific to @mui/lab component: speed dial This is the name of the generic UI component, not the React module! labels Apr 21, 2018
@mbrookes
Copy link
Member

mbrookes commented Apr 21, 2018 •
edited
Loading

As it is, it's impossible to see the tooltip on mobile because of the mouseover requirements.

While technically not true (you can press and hold to see the tooltip), it's neither intuitive nor convenient, and showing all the tooltips on mobile is a common pattern. Do you want to work on it?

@mbrookes mbrookes added the new feature New feature or request label Apr 21, 2018
@vudzero
Copy link
Author

vudzero commented Apr 22, 2018 •
edited
Loading

@mbrookes I just created a pull request, it is my first ever so please be easy on me! :)

I do have one issue though with the Tooltip when making it open as default, it seems that the tooltip position is not totally correct. Maybe you can pinpoint me where I should look at to fix this small issue

My pull request is #11103

@eps1lon
Copy link
Member

eps1lon commented Oct 3, 2018

Implemented by @hashwin in #12590 and released in @material-ui/[email protected].

Demo

@eps1lon eps1lon closed this as completed Oct 3, 2018
@oliviertassinari oliviertassinari removed the package: lab Specific to @mui/lab label Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: speed dial This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mbrookes @vudzero @oliviertassinari @eps1lon