[SpeedDial] Added tooltipOpen property to SpeedDialAction component #11103
Conversation
oliviertassinari
added
package: lab
|
Any update on the review for this? This is a must-have for my speed dial implementation. |
|
@hashwin We have been focussed on the final countdown to v1. I'll revisit the lab components after that. |
| /** | ||
| * Make the tooltip always visible. | ||
| */ | ||
| tooltipAlwaysOpen: PropTypes.bool, |
There was a problem hiding this comment.
Perhaps this should be an @ignored prop controlled by the SpeedDial? Thoughts?
Either way, tooltipOpen should be sufficient for the prop name.
pages/lab/speed-dial.js
Outdated
| @@ -19,7 +19,14 @@ module.exports = require('fs') | |||
| js: require('docs/src/pages/lab/speed-dial/OpenIconSpeedDial').default, | |||
| raw: preval` | |||
| module.exports = require('fs') | |||
| .readFileSync(require.resolve('docs/src/pages/lab/speed-dial/OpenIconSpeedDial'), 'utf8') | |||
| .readFileSync(require.resolve('docs/src/pages/lab/speed-dial/SpeedDialTooltipOpen'), 'utf8') | |||
| @@ -12,3 +12,7 @@ You can provide an alternate icon for the closed and open states using the `icon | |||
| of the `SpeedDialIcon` component. | |||
|
|
|||
| {{"demo": "pages/lab/speed-dial/OpenIconSpeedDial.js"}} | |||
|
|
|||
| Actions tooltip can be set to always visible to prevent long press on mobile platform. | |||
There was a problem hiding this comment.
"The SpeedDialActions tooltips can be be displayed persistently so that users don't have to long-press in order to see the tooltip on touch devices.
It is enabled here across all devices for demo purposes, but in production could use the isTouch logic to conditionally set the property."
|
@MatxBerg any plans on updating this pr? Hoping to use this feature from the lab soon. |
|
@Auchindoun Sorry I don't have write access to complete this PR... |
|
@MatxBerg I'm confused, it looks like the PR is based off of your fork though? |
|
Yes but I can't merge it back myself on the main repo.
…On Wed, Jun 6, 2018 at 10:20 AM Nathaniel Cook ***@***.***> wrote:
@MatxBerg <https://github.com/MatxBerg> I'm confused, it looks like the
PR is based off of your fork though? MatxBerg:speeddial-label-visibility
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11103 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC1fbTatSKxUc9rwIvH1oTbqP9JRJ9Kqks5t5-UXgaJpZM4TfAMG>
.
--
*Mathieux Bergeron*
438-887-6603
|
|
@MatxBerg That doesn't prevent you from updating the PR though. I gave some feedback 3 weeks ago, but it's still pending. If you don't have time, no problem, but wanted to give you the opportunity to finish up the PR. |
|
@mbrookes I'm very sorry, it's my first PR EVER so I kind of don't know the whole process. Can you just pinpoint what are the steps? |
|
@MatxBerg IF you could correct the issues raised here (#11103 (review)) and push the commit to you repo. One of those is a discussion point - you can reply inline. |
mbrookes
changed the title
|
@MatxBerg I updated your PR based on the feedback I left in May, however there are still a couple of problems with the current implementation. Because the Tooltip is opening immediately, its positioning with respect to the Action is incorrect:
That may be an artifact of the recent Popper / Tooltip changes (@oliviertassinari ?) Even so, the Tooltip should be appearing in coordination with the Action rather than all at once. Since this PR has been dormant for some time, I'm closing for now. Feel free to reopen it i you have time to work on it. @Auchindoun - feel free to pick it up if you need this feature sooner. |
|
It would be great if this could be added |
|
I'm going to work on getting this done since the last issue was closed. I have a working version, just need to tweak the position of the label in relation to the button. |
Added always open options to SpeedDialAction component
Closes #11564