-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal onClose error: Cannot read property 'removeAttribute' of null #13349
Comments
I encountered this problem earlier. manageAriaHidden.js#ariaHidden check code( |
* fix: fixes #13349 * add a regression test
@jeffy-g Yes, it was. This defensive check was hidding something. We have already found one hidden problem. |
As a temporary measure, I've been able to resolve this issue by rolling back to @material-ui/[email protected] and version locking the package.json
|
We will do a quick release with the fix. I suspect there is more. |
📦 v3.3.1 was just released. A regression test was added to prevent it to happen a second time in the future. We are sorry for the annoyance. I think that I will change the release schedule a bit. It's safer to release every Saturday (instead of Sunday). It should let time to fix the regressions Sunday before the week starts (+70% of the usage). If the problem persists, please open an issue with a reproduction example. Thank you! |
I'm following this exact example, but when I open up the menu and click to close the menu... then the application crashes with the below error:
Example used:
https://material-ui.com/demos/menus/#selected-menus
Deps:
"@material-ui/core": "^3.3.0",
"@material-ui/icons": "^3.0.1",
"typescript": "^3.1.3"
The text was updated successfully, but these errors were encountered: